[Koha-patches] [PATCH] Replace TMPL_ELSIF with TMPL_ELSE and TMPL_IF in label-manager.tmpl;

[Mason James]

On 2008/07/29, at 11:37 PM, MJ Ray wrote:

> "Joe Atzberger" <joe.atzberger at liblime.com> wrote:
>> On Mon, Jul 28, 2008 at 1:18 PM, MJ Ray <mjr at phonecoop.coop> wrote:
>>> It doesn't seem to work reliably on one of my Koha 3 systems.
>>> TMPL_ELSIF appears to be a fairly recent HTML::Template::Pro-ism  
>>> so it
>>> limits portability and there's a big WARNING on perldoc
>>> HTML::Template::SYNTAX, so it seemed like a good idea to remove it.
>>> What's the problem?
>>
> Consider this the first, then!
> http://rt.cpan.org/Ticket/Display.html?id=38013



Hi Guys

I've just got round to reading back on this thread , and heres my 2  
cents...

I've just built HTML-Template-Pro-0.70 fine on my OSX 10.4 box, 1st  
go even.
MJR, This may well be an issue with your specific system alone?,

I think we do need to properly prove that H:T:P's ELSIF's are buggy  
before we remove them,
as they make the template logic a lot saner

So, we need to find a second-case? of H:T:P failing on an OSX box..  
but until then - I think we should continue to commit to H:T:P
H:T:P seems to be behaving pretty well, I think we should trust it  
and make use of its nicer features
And I'm pretty sure that with some help and persistent we can sort  
out MJR's OSX H:T:P build issue.

MJR, if you want a hand to compare OSX systems, just sing out on irc ;)


Mason



---------
wasabi:~ masonjames$ uname -a
Darwin wasabi 8.11.1 Darwin Kernel Version 8.11.1: Wed Oct 10  
18:23:28 PDT 2007; root:xnu-792.25.20~1/RELEASE_I386 i386 i386


Manifying blib/man3/HTML::Template::Pro.3
   VIY/HTML-Template-Pro-0.70.tar.gz
   make -- OK
Running make test
PERL_DL_NONLAZY=1 /opt/local/bin/perl "-MExtUtils::Command::MM" "-e"  
"test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/01coderefs..............ok
t/02basic.................ok
t/02random................ok
t/03complex...............ok
t/04register..............ok
t/HTML-Template-Expr......ok
t/HTML-Template-Pro.......ok
t/HTML-Template...........ok
t/pod.....................ok
t/realloc.................ok
All tests successful.
Files=10, Tests=393,  0 wallclock secs ( 0.09 usr  0.05 sys +  0.40  
cusr  0.17 csys =  0.71 CPU)
Result: PASS
   VIY/HTML-Template-Pro-0.70.tar.gz
   make test -- OK
Running make install
Prepending /Users/masonjames/.cpan/build/HTML-Template-Pro-0.70- 
gE7C5H/blib/arch /Users/masonjames/.cpan/build/HTML-Template-Pro-0.70- 
gE7C5H/blib/lib to PERL5LIB for 'install'
Files found in blib/arch: installing files in blib/lib into  
architecture dependent library tree
Installing /opt/local/lib/perl5/site_perl/5.8.8/darwin-2level/auto/ 
HTML/Template/Pro/Pro.bundle
Installing /opt/local/lib/perl5/site_perl/5.8.8/darwin-2level/HTML/ 
Template/Pro.pm
Installing /opt/local/lib/perl5/site_perl/5.8.8/darwin-2level/HTML/ 
Template/SYNTAX.pod
Installing /opt/local/share/man/man3/HTML::Template::Pro.3
Installing /opt/local/share/man/man3/HTML::Template::SYNTAX.3
Writing /opt/local/lib/perl5/site_perl/5.8.8/darwin-2level/auto/HTML/ 
Template/Pro/.packlist
Appending installation info to /opt/local/lib/perl5/5.8.8/ 
darwin-2level/perllocal.pod
   VIY/HTML-Template-Pro-0.70.tar.gz
   make install  -- OK