[Koha-patches] [PATCH] BUGFIX fix on 2380 fix, dump to 102

[paul POULAIN]

Ryan Higgins a écrit :
>
> I was very frustrated by my disappearing multiline commit messages, 
> but just
> the other day found the trick behind it :  You have to have a blank 
> line after your
> first line.  So the format must be:
>
> One line summary
>
> Multiline commit description
> that follows a blank line.  Without that
> blank line, git-send-email will throw away this part.
>
>  ...  hope that helps, as I was very confused about it for longer than 
> I probably should
> have been :)

Hi Ryan,

I knew that trick but "hélas", it's not enough for the ML.
The commit comment of the previous patch is :
 >    BUGFIX fix on 2380 fix, dump to 102
 >  
 >    If you have invalid data in your serialitems table, the constraint 
can't be set.
 >    this patch delete any invalid data before adding the constraint.
 >    No need to add a 104 : if you had no error in your datas, previous 
102 worked fine.

so it has a blank like, but that's not enough for the ML.

About 1st line summary : iirc, it's also suggested that it is <80 char long.

-- 
Paul POULAIN
http://www.biblibre.com
Expert en Logiciels Libres pour l'info-doc
NOUVEAU TELEPHONE : 04 91 81 35 08