[Koha-patches] [PATCH] Serials planning: Update subscription edit to properly deal with date changes. ( patch 3 / 3 )

[Henri-Damien LAURENT]

Ryan Higgins a écrit :
> Previously subscription-add.pl allowed modification of 'firstacquidate', which changed
> the subscription definition, but did not affect prediction.  This patch adds two fuctions
> to Serials.pm to get/set the current expected issue date (note that all date calculations
> in prediction patterns are based on the current expected date, and there's only one serial
> issue per subscription in the 'expected' status at any time).  Subscription editing
> now allows you to edit the next expected date, but not the first acqui date (unless you
> haven't received any issues yet), thus allowing for adjustments in the prediction pattern.
> This patch also updates fixes some discrepancies in irregularities / prediction display.
>   
Ryan,
you did good job with those patches :
I like the way you can select irregularities (with dates proposed, this 
was what I wanted to propose ( with eventually a feature that would 
create all the expected issues at once (this would be of great help for 
dead subscriptions cataloguing) )).
I like the way you mark readonly the first arrival date on editing a 
subscription.

So well done.


However, some behaviours are still questioning.
- one cannot see the irregularities when editing a subscription : you 
have to reset Predicition pattern for test Prediction Pattern to be 
re-enabled. Is this what you/we intend ?
- When updating the arrival date of the first expected issue, 
firstacquidate is not updated. Is this what we want ?
- when duplicating a subscription, irregularities information is not 
duplicated. Is this intended ? Imho, an irregularities hidden input 
could store all the irregularities selected the way irregularities 
stores them and this would be duplicated when subscription duplicated.
- There is little control on the number of irregularities entered. I am 
OK with that (It is not critical).

Friendly

-- 
Henri-Damien LAURENT
BibLibre SARL
http://www.biblibre.com
Expert en Logiciels Libres pour l'info-doc
tel : +33 4 67 65 75 50