[Koha-patches] [PATCH] Serials planning: Update subscription edit to properly deal with date changes. ( patch 3 / 3 )

[Henri-Damien LAURENT]

Ryan Higgins a écrit :
>
>
> On Mon, Aug 4, 2008 at 4:58 AM, Henri-Damien LAURENT 
> <henridamien at koha-fr.org <mailto:henridamien at koha-fr.org>> wrote:
>
>     you did good job with those patches :
>     I like the way you can select irregularities (with dates proposed,
>     this was what I wanted to propose ( with eventually a feature that
>     would create all the expected issues at once (this would be of
>     great help for dead subscriptions cataloguing) )).
>
>
> Yes, this feature is *very* high on my list, too, and should be pretty 
> easy to implement.

> No, this is not intended.  I just applied these patches to a clean 
> branch, and I see this error now.
> It must have crept in while rebasing the commits.  I'll submit another 
> patch to correct this in a couple hours.
>
>     - When updating the arrival date of the first expected issue,
>     firstacquidate is not updated. Is this what we want ?
>
>  
> No, if we have not yet received any issues, then it should be 
> modified.  Again, a fix that was lost on rebase.
> I will correct this as well.
>
>     - when duplicating a subscription, irregularities information is
>     not duplicated. Is this intended ? Imho, an irregularities hidden
>     input could store all the irregularities selected the way
>     irregularities stores them and this would be duplicated when
>     subscription duplicated.
>
>
> I did not address this in these patches.  I agree that that should be 
> the expected behavior, but do not expect that
> I will have time to add this.
>

I think I can do this. Can you tell me if there is an input you store 
irregularities in which would not be created by js ?
I will wait for your patches though.
>
>     - There is little control on the number of irregularities entered.
>     I am OK with that (It is not critical).
>
>
> I agree.  It would be nice to keep a count of how many irregularities 
> Koha expects the user to enter.
> That would be a nice enhancement.
>
> Thanks for testing these patches so quickly, and catching the above 
> errors.
> I will submit a couple patches to address those errors later today.
You're welcome.
I had been working on this with no success because I wanted to doo too 
many things at once.
It is a pleasure to cooperate.

-- 
Henri-Damien LAURENT
BibLibre SARL
http://www.biblibre.com
Expert en Logiciels Libres pour l'info-doc
tel : +33 4 67 65 75 50