[Koha-patches] [PATCH] kohabug 2491 Improving error trapping and communication w/user

[Galen Charlton]

Hi Chris,

On Tue, Aug 12, 2008 at 6:58 PM, Chris Nighswonger
<chris.nighswonger at liblime.com> wrote:
> This patch adds code to indicate why a rule is not saved when the "Delay" field is left
> blank.
>
> The patch also corrects a condition which caused the form not to display current rules for
> the selected branch.
>
> It also adds the ability to delete a rule.
>
> Documentation note: Docs will need to be updated as the template has changed to add a
> "Delete" checkbox column to the rules table when displaying existing rules.

There is a glitch in the error message logic.  If you're starting off
with no rules set up for a library and add two rules, each with a
different error, the error message can be misleading.

For example (assuming you're using the default English patron
categories), try the following:

Patron category "Board", delay 1 = 5 and action = debar, delay 2 = 2
and action = debar
Patron category "Home bound", delay is blank, delay 2 = 5 but no
action specified.

Each of these entries has a problem - for Board, the second delay is
less than the first one; for "Home Bound", no action is specified for
delay 2.  However, the error message you get is:

"No letter or debar action specified for delay second delay for Board
borrower category. If a delay is supplied, either a letter, debar
action, or both should be specified."

A correct error message, but the wrong patron category.

I'm not sure I care much whether the error message describes all of
the errors or just the first one, although reporting all of them might
be more useful, but any errors it does report should be correct.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt