[Koha-patches] [PATCH] bug 2518: remove useless patron and branch lookups

Galen Charlton galen.charlton at liblime.com
Thu Aug 14 17:43:06 CEST 2008


AddIssue does not use the results of the lookup
of the patron whose hold request was preempted
by the issue.  This patch now leaves a no-op in
the '$restype eq "Waiting"' test, but I'm not going to
refactor the hold cancellation logic now.
---
 C4/Circulation.pm |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/C4/Circulation.pm b/C4/Circulation.pm
index ca52e27..9e97d47 100644
--- a/C4/Circulation.pm
+++ b/C4/Circulation.pm
@@ -909,18 +909,11 @@ sub AddIssue {
 					# warn "Waiting";
 					# The item is on reserve and waiting, but has been
 					# reserved by some other patron.
-					my ( $resborrower ) = GetMemberDetails( $resbor, 0 );
-					my $branches   = GetBranches();
-					my $branchname =
-					  $branches->{ $res->{'branchcode'} }->{'branchname'};
 				}
 				elsif ( $restype eq "Reserved" ) {
 
 					# warn "Reserved";
 					# The item is reserved by someone else.
-					my ( $resborrower ) = GetMemberDetails( $resbor, 0 );
-					my $branches   = GetBranches();
-					my $branchname =  $branches->{ $res->{'branchcode'} }->{'branchname'};
 					if ($cancelreserve) { # cancel reserves on this item
 						CancelReserve( 0, $res->{'itemnumber'},
 							$res->{'borrowernumber'} );
-- 
1.5.5.GIT




More information about the Koha-patches mailing list