[Koha-patches] [PATCH] Bug 2524: improving the submitted test reports

[Andrew Moore]

switching from 'prove' to 'perl' to run the test scripts when we're preparing
them to be submitted to smolder. Prove adds an additional summary at the end
of the test run which confuses the TAP parser in smolder. It thinks that an
additional test has been run, and it fails it.

Then, I added a '-' before the command in the Makefile. THat's so that even
if 'perl' returns a failing code (because some tess failed), the rest of the
rules are run and a report gets submitted. Othewise, only passing reports
get sent.
---
 t/Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/t/Makefile b/t/Makefile
index a4ff5ec..2bad178 100644
--- a/t/Makefile
+++ b/t/Makefile
@@ -15,7 +15,7 @@ PERL = /usr/bin/perl
 TEST_FILES = database_dependent.pl
 TEST_CLASS =
 RUN_EXPENSIVE_TESTS = 0
-PROVE = /usr/bin/prove
+PROVE = /usr/local/bin/prove
 PROVE_FLAGS = -v
 PERL5LIB = ..
 KOHA_CONF_DIR = ../etc
@@ -106,6 +106,6 @@ $(SMOLDER_REPORT_TARBALL) :: $(SMOLDER_REPORT_FILENAME)
 $(SMOLDER_REPORT_FILENAME) :: report
 
 report :: config_file $(ZEBRA_CONF_FILES) $(SCRIPTS)
-	KOHA_CONF=$(TEST_CONF_FILE) PERL5LIB=$(PERL5LIB) TEST_CLASS=$(TEST_CLASS) RUN_EXPENSIVE_TESTS=$(RUN_EXPENSIVE_TESTS) \
-		$(PROVE) $(PROVE_FLAGS) $(TEST_FILES) > $(SMOLDER_REPORT_FILENAME)
+	-KOHA_CONF=$(TEST_CONF_FILE) PERL5LIB=$(PERL5LIB) TEST_CLASS=$(TEST_CLASS) RUN_EXPENSIVE_TESTS=$(RUN_EXPENSIVE_TESTS) \
+		$(PERL) $(TEST_FILES) > $(SMOLDER_REPORT_FILENAME)
 
-- 
1.5.6