[Koha-patches] [PATCH] Fixing 2516 : Ordering names with multiple keys

[Galen Charlton]

Hi Henri,

On Fri, Aug 22, 2008 at 10:19 AM, Henri-Damien LAURENT
<henridamien.laurent at biblibre.com> wrote:
> +    $orderby.=",firstname,othernames" if $orderby=~/name/;

I'm not sure how this patch fixes bug 2516 as described.  The
SearchMember call in circ/circulation.pl uses 'cardnumber' for
$orderby; furthermore, around line 529 of circ/circulation.pl, the
results of the SearchMember call are sorted again anyway:

    foreach (
        sort {
                lc $a->{'surname'}
              . lc $a->{'firstname'} cmp lc $b->{'surname'}
              . lc $b->{'firstname'}
        } @$borrowerslist
      )

Perhaps the fix needs to be there?

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt