[Koha-patches] [PATCH] bug 2505: turned on warnings for suggestion/acceptorreject.pl
Galen Charlton
galen.charlton at liblime.com
Thu Dec 11 00:30:03 CET 2008
Also fixed case where HTML could have unclosed <form> elements,
leading to warnings in the error log when accepting pending
or rejected suggestions.
---
.../prog/en/modules/suggestion/acceptorreject.tmpl | 5 ++---
suggestion/acceptorreject.pl | 2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/acceptorreject.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/acceptorreject.tmpl
index fd2f85a..507361a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/acceptorreject.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/acceptorreject.tmpl
@@ -235,6 +235,7 @@
<!--TMPL_IF EXPR="suggestiontype eq 'rejected'"-->
<b>No rejected suggestions.</b>
<!--/TMPL_IF-->
+</form>
<!-- /TMPL_IF -->
</div>
@@ -244,6 +245,4 @@
</div></div>
</div>
-</div>
-</div>
-<!-- TMPL_INCLUDE NAME="intranet-bottom.inc" -->
\ No newline at end of file
+<!-- TMPL_INCLUDE NAME="intranet-bottom.inc" -->
diff --git a/suggestion/acceptorreject.pl b/suggestion/acceptorreject.pl
index 5100334..cbc0b98 100755
--- a/suggestion/acceptorreject.pl
+++ b/suggestion/acceptorreject.pl
@@ -65,6 +65,7 @@ op can be :
=cut
use strict;
+use warnings;
use CGI;
@@ -139,7 +140,6 @@ if ( $op eq "aorr_confirm" ) {
$op = "else";
if (scalar(@deletelist)>0){
my $params = "&delete_field=".join ("&delete_field=", at deletelist);
- warn $params;
print $input->redirect("/cgi-bin/koha/suggestion/acceptorreject.pl?op=delete_confirm$params");
}
}
--
1.5.5.GIT
More information about the Koha-patches
mailing list