[Koha-patches] [PATCH] REFACTOR: correcting indirect object method syntax

Jesse Weaver jesse.weaver at liblime.com
Thu Dec 18 17:56:56 CET 2008


On Wed, Dec 17, 2008 at 3:31 PM, Andrew Moore <andrew.moore at liblime.com>wrote:

> ---
>  catalogue/detail.pl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/catalogue/detail.pl b/catalogue/detail.pl
> index 19b8dd9..fd2b177 100755
> --- a/catalogue/detail.pl
> +++ b/catalogue/detail.pl
> @@ -36,7 +36,7 @@ use C4::Amazon;
>
>  # use Smart::Comments;
>
> -my $query = new CGI;
> +my $query = CGI->new();
>  my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
>     {
>         template_name   => "catalogue/detail.tmpl",
> --
> 1.5.6
>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>

I know that some newer parts of Koha use "CGI->new", and most of it uses
"new CGI".

->new() seems to be a bit more kosher, but this is a very rough guess. Is
this something we should add to the coding guidelines on the wiki?

-- 
Jesse Weaver
Software Developer, LibLime
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-patches/attachments/20081218/0ea08311/attachment-0001.htm>


More information about the Koha-patches mailing list