[Koha-patches] [PATCH] Modifications to C4/Matcher for colon and ending punctuation

David Bavousett david.bavousett at liblime.com
Mon Dec 29 15:18:12 CET 2008


Andy,

I'm fine with deleting them.  In both of these instances, I'm just
passing along someone else's work.  She commented them out without
deleting, so I did, too.

-David

On Mon, Dec 29, 2008 at 8:15 AM, Andrew Moore <andrew.moore at liblime.com> wrote:
> Hey David -
>
> If these lines are really not used, should they be deleted? If the
> point is that they serve as documentation of what not to do, perhaps a
> comment explaining the regular expressions would be more informative.
>
> What are your thoughts?
>
> -Andy
>
>
> On Fri, Dec 26, 2008 at 4:18 PM, David Bavousett
> <david.bavousett at liblime.com> wrote:
>> sub _normalize {
>>    my $value = uc shift;
>> +    $value =~ s/.;:,\]\[\)\(\/'"//g;
>>    $value =~ s/^\s+//;
>> -    $value =~ s/^\s+$//;
>> +    #$value =~ s/^\s+$//;
>> +    $value =~ s/\s+$//;
>>    $value =~ s/\s+/ /g;
>> -    $value =~ s/[.;,\]\[\)\(\/"']//g;
>> +    #$value =~ s/[.;,\]\[\)\(\/"']//g;
>>    return $value;
>



More information about the Koha-patches mailing list