[Koha-patches] [PATCH] Allow editing of irregularities for an existing subscription.

Ryan Higgins rch at liblime.com
Sun Jul 27 20:27:12 CEST 2008


---
 serials/subscription-add.pl |   13 ++++---------
 1 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/serials/subscription-add.pl b/serials/subscription-add.pl
index e8002aa..cb64725 100755
--- a/serials/subscription-add.pl
+++ b/serials/subscription-add.pl
@@ -231,14 +231,7 @@ if ($op eq 'addsubscription') {
     print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid");
 } elsif ($op eq 'modsubscription') {
     my $subscriptionid = $query->param('subscriptionid');
-    my @irregular = $query->param('irregular');
-    my $irregular_count = @irregular;
-    for(my $i =0;$i<$irregular_count;$i++){
-      $irregularity .=$irregular[$i].",";
-      warn "irregular : $irregular[$i] string :$irregularity";
-    }
-    $irregularity =~ s/\,$//;
-
+	my @irregularity = $query->param('irregularity_select');
     my $auser = $query->param('user');
     my $librarian => $query->param('librarian'),
     my $branchcode = $query->param('branchcode');
@@ -297,13 +290,15 @@ if ($op eq 'addsubscription') {
     my $opacnote = $query->param('opacnote');
     my $librariannote = $query->param('librariannote');
     my $history_only = $query->param('history_only');
+	# FIXME:  If it's  a mod, we need to check the current 'expected' issue, and mod it in the serials table if necessary.
+	#
     if ($history_only) {
         ModSubscriptionHistory ($subscriptionid,$histstartdate,$histenddate,$recievedlist,$missinglist,$opacnote,$librariannote);
     } else {
         &ModSubscription(
             $auser,           $branchcode,   $aqbooksellerid, $cost,
             $aqbudgetid,      $startdate,    $periodicity,    $firstacquidate,
-            $dow,             $irregularity, $numberpattern,  $numberlength,
+            $dow,             join(",", at irregularity), $numberpattern,  $numberlength,
             $weeklength,      $monthlength,  $add1,           $every1,
             $whenmorethan1,   $setto1,       $lastvalue1,     $innerloop1,
             $add2,            $every2,       $whenmorethan2,  $setto2,
-- 
1.5.5.GIT




More information about the Koha-patches mailing list