[Koha-patches] [PATCH] Replace TMPL_ELSIF with TMPL_ELSE and TMPL_IF in label-manager.tmpl;

[Joshua Ferraro]

On Tue, Jul 29, 2008 at 11:53 AM, MJ Ray <mjr at phonecoop.coop> wrote:
> "Joe Atzberger" <joe.atzberger at liblime.com> wrote:
>> On Tue, Jul 29, 2008 at 7:37 AM, MJ Ray <mjr at phonecoop.coop> wrote:
>> > HTML::Template::SYNTAX is part of HTML::Template::Pro.
>>
>> Yes, and what that syntax says is that ELSIF is part of Pro.  That's the
>> connection.  The warning you cited does not apply to us.
>
> The warning applies: it still stops the templates being portable, so
> makes it harder for us to switch if HTP has showstoppers found later.
>
>> > http://rt.cpan.org/Ticket/Display.html?id=38013
>>
>> Not sure what else might be problematic in that MacOS installation of perl.
>> If I read your report correctly, it looks like HTML::Template::Expr is
>> actually the component that failed.
>
> I think that's misreading the report: t/HTML-Template-Expr tests
> HTML::Template::Pro's implementation of TMPL_EXPR, I think.  I'm not
> sure why it's got that name.
>
>> You seem to have version 5.8.8 on OS 10.5.x.   I only have 5.8.6 on 10.4.11
>> on my MacBook, for what it's worth, but H:T:P installed cleanly on this
>> one.  My H:T:Expr version is 0.07.  Log for comparison:
>>   http://pastebin.com/m7bce216c
>
> H:T:Expr isn't installed and it's not required by Koha or HTP, is it?
>
> I can't sell a downgrade to 10.4 to that server because I understand
> that its owners need some features for backups that are new in 10.5.
> Previous HTPs work without TMPL_ELSIF, hence the patch.
We do have code that uses EXPR.

Josh



-- 
Joshua Ferraro SUPPORT FOR OPEN-SOURCE SOFTWARE
CEO migration, training, maintenance, support
LibLime Featuring Koha Open-Source ILS
jmf at liblime.com |Full Demos at http://liblime.com/koha |1(888)KohaILS