[Koha-patches] [PATCH] kohabug 2345: bad comparisons pervade reports
paul POULAIN
paul.poulain at biblibre.com
Thu Jul 31 14:37:37 CEST 2008
Jesse Weaver a écrit :
> This patch changes all $foo eq undef's to !defined($foo). It also makes misc/spellcheck_suggest/build_spellcheck_suggest.pl have proper syntax.
>
Just a quick question : is this change made because :
- the previous code is buggy ?
- the previous code is considered poor in Perl officially ?
- the previous code is considered poor in Perl by you ?
- there's a noticeable perf difference ?
just to know, I don't see any difference between
> $x eq undef
and
> defined($x)
thanks
--
Paul POULAIN
http://www.biblibre.com
Expert en Logiciels Libres pour l'info-doc
NOUVEAU TELEPHONE : 04 91 81 35 08
More information about the Koha-patches
mailing list