[Koha-patches] [PATCH] Replace TMPL_ELSIF with TMPL_ELSE and TMPL_IF in label-manager.tmpl;

MJ Ray mjr at phonecoop.coop
Thu Jul 31 18:53:29 CEST 2008


"Joe Atzberger" <joe.atzberger at liblime.com> wrote:
> On Thu, Jul 31, 2008 at 9:45 AM, MJ Ray <mjr at phonecoop.coop> wrote:
> > "Chris Nighswonger" <chris.nighswonger at liblime.com> wrote: [...]
> > > BTW: TMPL_ELSIF is presently used in at least 55 lines of code.
> >
> > So let's remove it while it's still easy.
>
> What you are talking about removing the ELSIF's *in order* to be able to
> substitute HTML::Template for HTML::Template::Pro.

No, I'm talking about removing the ELSIFs to ease portablity of
templates between Koha and other HT-based tools, as well as getting
Koha behaving reliably with currently-fully-working H:T:P versions.

[...]
> Given that Koha doesn't use EXPR for large number arithmetic, and you didn't
> see any other errors, you could also just force the install.  In the end, I
> don't see any reason, including fixing your affected systems, to make these
> changes in the Koha codebase.

Maybe it would be good to ask for the reason instead before claiming:
1. that system is unsupported;
2. the problem is local to that system;
3. the problem is with HTML::Template::Expr; or
4. I'm wanting to revert all of Koha to HTML::Template.

Credit to Joshua for simply asking why and making small comments, and
fine if he doesn't include any patches in this direction, but this
"there is no reason not to use single-author extensions instead of the
portable way" subthread is really frustrating.

Regards,
-- 
MJ Ray (slef)
Webmaster for hire, statistician and online shop builder for a small
worker cooperative http://www.ttllp.co.uk/ http://mjr.towers.org.uk/
(Notice http://mjr.towers.org.uk/email.html) tel:+44-844-4437-237



More information about the Koha-patches mailing list