[Koha-patches] [PATCH] DB update for 'editholdings' permission.

[Galen Charlton]

Hi Mason,

I'm confused about a couple things:

On Tue, May 13, 2008 at 3:17 PM, Mason James
<mason.loves.sushi at gmail.com> wrote:
>  +    $dbh->do("UPDATE userflags set bit = 18 where bit = 10");

This is moving the updatecharges flag (bit = 10) to bit 18?  Why?

>  +    $dbh->do("UPDATE userflags set flagdesc = 'Edit Catalogue (Modify bibliographic-level data)'  where flag = 'editcatalogue')");

This is not correct for a French catalog - the installed staff
language should be checked if possible.

>  +    $dbh->do("INSERT INTO `userflags` VALUES (10,'editholdings',' Edit Holdings  (Modify holdings-level data)',0");

Why not add the editingholdings flag as bit 18?  Also, I suggest
calling it edititems instead of editholdings - the change is referring
to editing item records, i.e., those accessed via C4::Items.  The
problem with "holdings" is that although in some library usage it is
equivalent to "items", for many libraries "holdings" (as a summary of
grouped items) is distinct from "items".  Also, internally very little
in the code uses "holdings".

I think a couple things are missing:

* The patch would seem to have the effect of making a staff user who
has editcatalogue suddenly be unable to edit item records, which they
could do before.  This would be disruptive to somebody using alpha or
beta - I think the upgrade should go through all staff user records
and given edititems to every staff user who has editcatalogue.
* Unless this is in the separate patch you haven't sent yet, the
default useruser flags scripts (i.e.,
installer/data/mysql/en/mandatory/userflags.sql  and
installer/data/mysql/fr-FR/1-Obligatoire/userflags.sql) should include
the new flag.

Regards,

Galen
-- 
Galen Charlton
Koha Application Developer
LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709