[Koha-patches] [PATCH] Bug Fixing : ModMember and memberentrygen.tmpl

Ryan Higgins ryan.higgins at liblime.com
Fri May 16 01:52:54 CEST 2008


I very much agree that use of TMPL EXPR should be avoided when possible.


On Thu, May 15, 2008 at 6:06 PM, Joe Atzberger <joe.atzberger at liblime.com>
wrote:

>
> On Thu, May 15, 2008 at 3:47 PM, Henri-Damien LAURENT <
> henridamien.laurent at biblibre.com> wrote:
>
>> -<!--TMPL_IF EXPR="showguarantor"-->  <li><label for="">Guarantor:
>> </label>
>> +<!--TMPL_IF EXPR="showguarantor"--><input type="hidden"
>> name="guarantorid"   value="<!-- TMPL_VAR NAME="guarantorid" -->" />
>> +  <li><label for="">Guarantor: </label>
>>   <select name="relationship" id="relationship" >
>>
>
> This appears to be a good chance to NOT to use EXPR, since it is really
> just a regular NAME parameter test.  The form:
> <!--TMPL_IF NAME="showguarantor"-->
> will achieve the same results without encouraging the problematic EXPR.
>
> --Joe
>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>
>


-- 
Ryan Higgins

LibLime * Open-Source Solutions for Libraries
Featuring KohaZOOM ILS
888-564-2457 x704
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-patches/attachments/20080515/93cbe307/attachment-0003.htm>


More information about the Koha-patches mailing list