[Koha-patches] [PATCH] Bug Fix : Creating a new authority type would fail on creating subfield_structure
Galen Charlton
galen.charlton at liblime.com
Wed May 21 16:00:14 CEST 2008
Hi,
On Wed, May 21, 2008 at 3:57 AM, MJ Ray <mjr at phonecoop.coop> wrote:
> As I understand it, some database drivers will rollback any changes
> made if the DB handle is DESTROYed rather than a commit/disconnect.
> Not a problem while MySQL is the main game, but could hurt later.
> Also, how does mod_perl behave if you don't disconnect?
Good point. In order to do this automatically, we could put the DB
handle disconnect in the END block of C4::Context. My issue with
doing it *explicitly* in a script or module is that it is easy to
either forget, or to close a handle too early and force the expense of
getting a fresh one (i.e., I just noticed the disconnects in two
functions in C4::Overdues, which I suspect don't belong).
Regards,
Galen
--
Galen Charlton
Koha Application Developer
LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
More information about the Koha-patches
mailing list