[Koha-patches] [PATCH] Fines repair. Make fines2.pl work, give feedback, improve comments and perldoc.

Andrew Moore andrew.moore at liblime.com
Thu May 29 14:54:55 CEST 2008


On Tue, May 27, 2008 at 6:06 PM, Joe Atzberger
<joe.atzberger at liblime.com> wrote:
> -
> -    my @results;
> -    while ( my $data = $sth->fetchrow_hashref ) {
> -        push @results, $data;
> -    }
> -    $sth->finish;
> -
> -    return \@results;
> +       return $sth->fetchall_arrayref({});
>  }

Hi Joe -

Thanks for making this change. It looks like this idiom is used in
many places throughout koha, and I'd love to see each use replaced
like this everywhere that it makes sense.

-Andy



More information about the Koha-patches mailing list