[Koha-patches] [PATCH] followup - make barcode_to_borrowernumber an internal function
Galen Charlton
galen.charlton at liblime.com
Tue Nov 4 21:34:52 CET 2008
From: Joe Atzberger (siptest <atz4sip at arwen.metavore.com>
Set this function apart with _ since it is not OO like the rest.
Signed-off-by: Galen Charlton <galen.charlton at liblime.com>
---
C4/SIP/ILS/Item.pm | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm
index 5afcf1d..2a4f850 100644
--- a/C4/SIP/ILS/Item.pm
+++ b/C4/SIP/ILS/Item.pm
@@ -234,10 +234,10 @@ sub available {
return 0;
}
-sub barcode_to_borrowernumber ($) {
+sub _barcode_to_borrowernumber ($) {
my $known = shift;
(defined($known)) or return undef;
- my $member = GetMember($known, 'cardnumber') or return undef; # borrowernumber is default type for GetMember lookup
+ my $member = GetMember($known,'cardnumber') or return undef;
return $member->{borrowernumber};
}
sub barcode_is_borrowernumber ($$$) { # because hold_queue only has borrowernumber...
@@ -245,7 +245,7 @@ sub barcode_is_borrowernumber ($$$) { # because hold_queue only has borrowern
my $barcode = shift;
my $number = shift or return undef; # can't be zero
(defined($barcode)) or return undef; # might be 0 or 000 or 000000
- my $converted = barcode_to_borrowernumber($barcode) or return undef;
+ my $converted = _barcode_to_borrowernumber($barcode) or return undef;
return ($number eq $converted); # even though both *should* be numbers, eq is safer.
}
1;
--
1.5.5.GIT
More information about the Koha-patches
mailing list