[Koha-patches] [PATCH] POD adjustments, in particular mention of $needsconfirmation

Galen Charlton galen.charlton at liblime.com
Tue Nov 4 21:49:07 CET 2008


Hi,

This patch causes the POD correctness test (prove
xt/author/podcorrectness.t) to fail.  Please fix and resubmit.

Regards,

Galen

On Thu, Oct 30, 2008 at 12:15 AM, Joe Atzberger
<joe.atzberger at liblime.com> wrote:
> ---
>  C4/Circulation.pm |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/C4/Circulation.pm b/C4/Circulation.pm
> index fb0cbb0..35e3ad3 100644
> --- a/C4/Circulation.pm
> +++ b/C4/Circulation.pm
> @@ -110,7 +110,7 @@ Also deals with stocktaking.
>
>  =head2 barcodedecode
>
> -=head3 $str = &barcodedecode($barcode);
> +$str = &barcodedecode($barcode);
>
>  =over 4
>
> @@ -158,7 +158,7 @@ sub barcodedecode {
>
>  =head2 decode
>
> -=head3 $str = &decode($chunk);
> +$str = &decode($chunk);
>
>  =over 4
>
> @@ -552,7 +552,7 @@ Check if a book can be issued.
>
>  ( $issuingimpossible, $needsconfirmation ) =  CanBookBeIssued( $borrower, $barcode, $duedatespec, $inprocess );
>
> -C<$issuingimpossible> and C<$needsconfirmation> are some hashref.
> +C<$issuingimpossible> and C<$needsconfirmation> are hashrefs.
>
>  =over 4
>
> @@ -570,11 +570,9 @@ Returns :
>
>  =over 4
>
> -=item C<$issuingimpossible> a reference to a hash. It contains reasons why issuing is impossible.
> +=item C<$issuingimpossible> a reference to a hash containing reasons why issuing is impossible.
>  Possible values are :
>
> -=back
> -
>  =head3 INVALID_DATE
>
>  sticky due date is invalid
> @@ -607,7 +605,7 @@ item withdrawn.
>
>  item is restricted (set by ??)
>
> -C<$issuingimpossible> a reference to a hash. It contains reasons why issuing is impossible.
> +=item C<$needsconfirmation> a reference to a hash containing overrideable issues that require confirmation.
>  Possible values are :
>
>  =head3 DEBT
> @@ -634,6 +632,8 @@ sticky due date is invalid
>
>  if the borrower borrows to much things
>
> +=back
> +
>  =cut
>
>  sub CanBookBeIssued {
> --
> 1.5.5.GIT
>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>



-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt



More information about the Koha-patches mailing list