[Koha-patches] [PATCH] Bug #2756 opacbookbag preference turns off add items to list

[Galen Charlton]

Hi Allen,

I found a couple issues when testing this patch:

* When opacbookbag is OFF and virtualshelves is ON, if you select
records from search results and try to add them to a list, the popup
window doesn't appear.  It is necessary to turn opacbookbag ON for
that to work (FF3 on OS X).
* When opacbookbag is ON and virtualshelves is OFF (i.e., the opposite
condition of the bug report), this patch loses the ability to add
items to the cart from the search results.

In other words, both carts and list functionality support adding items
from the search results, and the two options need to be orthogonal.

Please fix and resubmit.

Regards,

Galen

On Tue, Nov 4, 2008 at 4:58 PM, Allen Reinmeyer
<allen.reinmeyer at liblime.com> wrote:
> opacbookbag status was wrongly linked to adding items to lists.  There was also a bug in the javascript that prevented the 'select all','clear all' and the 'add-to' list.
> ---
>  .../opac-tmpl/prog/en/modules/opac-results.tmpl    |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tmpl
> index 17eef0c..96cd0d0 100644
> --- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tmpl
> +++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tmpl
> @@ -13,7 +13,7 @@
>  <script type="text/javascript">
>  //<![CDATA[
>  $(document).ready(function(){
> -       var param1 = "<label for=\"addto\">Add to: <\/label><select name=\"addto\" id=\"addto\"><option value=\"\"><\/option>"<!-- TMPL_IF name="opacbookbag" -->+"<option value=\"addtocart\">Cart<\/option>"+<!-- /TMPL_IF --><!-- TMPL_IF NAME="virtualshelves" --><!-- TMPL_IF NAME="loggedinusername" -->"<optgroup label=\"Your Lists:\">"+<!-- TMPL_IF NAME="addbarshelves" --><!-- TMPL_LOOP NAME="addbarshelvesloop" -->"<option id=\"s<!-- TMPL_VAR NAME="shelfnumber" -->\" value=\"addtolist\"><!-- TMPL_VAR NAME="shelfname" ESCAPE="html"--><\/option>"+<!-- /TMPL_LOOP --><!-- /TMPL_IF -->"<\/optgroup>";
> +       var param1 = "<label for=\"addto\">Add to: <\/label><select name=\"addto\" id=\"addto\"><option value=\"\"><\/option>"<!-- TMPL_IF name="opacbookbag" -->+"<option value=\"addtocart\">Cart<\/option>"<!-- /TMPL_IF -->+<!-- TMPL_IF NAME="virtualshelves" --><!-- TMPL_IF NAME="loggedinusername" -->"<optgroup label=\"Your Lists:\">"+<!-- TMPL_IF NAME="addbarshelves" --><!-- TMPL_LOOP NAME="addbarshelvesloop" -->"<option id=\"s<!-- TMPL_VAR NAME="shelfnumber" -->\" value=\"addtolist\"><!-- TMPL_VAR NAME="shelfname" ESCAPE="html"--><\/option>"+<!-- /TMPL_LOOP --><!-- /TMPL_IF -->"<\/optgroup>";
>        param1 += "<optgroup label=\"Public Lists:\">"+<!-- TMPL_IF NAME="addpubshelves" --><!-- TMPL_LOOP NAME="addpubshelvesloop" -->"<option id=\"s<!-- TMPL_VAR NAME="shelfnumber" -->\" value=\"addtolist\"><!-- TMPL_VAR NAME="shelfname" ESCAPE="html"--><\/option>"+<!-- /TMPL_LOOP --><!-- /TMPL_IF -->"<\/optgroup><option value=\"newlist\">[ New List ]<\/option>"+<!-- TMPL_ELSE -->"<optgroup label=\"Public Lists:\">"+<!-- TMPL_IF NAME="addpubshelves" --><!-- TMPL_LOOP NAME="addpubshelvesloop" -->"<option id=\"s<!-- TMPL_VAR NAME="shelfnumber" -->\" value=\"addtolist\"><!-- TMPL_VAR NAME="shelfname" ESCAPE="html"--><\/option>"+<!-- /TMPL_LOOP --><!-- /TMPL_IF -->"<\/optgroup>"+<!-- /TMPL_IF --><!-- /TMPL_IF -->"<\/select> <input type=\"submit\" class=\"submit\" value=\"Save\" />";
>        $('#sortsubmit').hide();
>     $('#sort_by').change(function() {
> @@ -164,7 +164,7 @@ $(document).ready(function(){
>         <table>
>                <tr><td colspan="5" class="resultscontrol" style="border : 1px solid #e8e8e8;">
>                <div class="resort"> <select id="sort_by" name="sort_by"> <!--TMPL_INCLUDE NAME="resort_form.inc"--> </select> <input type="submit" class="submit clearfix" id="sortsubmit" value="Go" /></div>
> -        <!-- TMPL_IF EXPR="opacbookbag || virtualshelves" --><div class="cartlist"><span class="checkall"></span>
> +        <!-- TMPL_IF EXPR=" virtualshelves" --><div class="cartlist"><span class="checkall"></span>
>                <span class="clearall"></span>
>                <span class="addto"></span></div>
>                <!-- /TMPL_IF -->
> @@ -178,7 +178,7 @@ $(document).ready(function(){
>                 <tr>
>             <!-- /TMPL_UNLESS -->
>
> -                <td class="select selectcol"><!--TMPL_IF EXPR="opacbookbag || virtualshelves" --><input type="checkbox" id="bib<!-- TMPL_VAR NAME="biblionumber" -->" name="biblionumber" value="<!-- TMPL_VAR NAME="biblionumber" -->" title="Click to add to cart" /> <label for="bib<!-- TMPL_VAR NAME="biblionumber" -->"></label><!-- /TMPL_IF --></td>
> +                <td class="select selectcol"><!--TMPL_IF EXPR="virtualshelves" --><input type="checkbox" id="bib<!-- TMPL_VAR NAME="biblionumber" -->" name="biblionumber" value="<!-- TMPL_VAR NAME="biblionumber" -->" title="Click to add to cart" /> <label for="bib<!-- TMPL_VAR NAME="biblionumber" -->"></label><!-- /TMPL_IF --></td>
>                 <td class="select selectcol"><!-- TMPL_VAR NAME="result_number" -->.</td>
>
>                                <!-- TMPL_UNLESS NAME="item-level_itypes" -->
> --
> 1.5.5.GIT
>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>



-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt