[Koha-patches] [PATCH] fix 2419

Marc Chantreux marc.chantreux at biblibre.com
Fri Oct 10 03:03:09 CEST 2008


On Thu, Oct 09, 2008 at 05:20:46PM -0400, Joe Atzberger wrote:
> > The ideal (but a bit ugly) way to never have to think about that is to use
> > ....

> This is the model that I try to follow, and explains the block in Koha that
> you will see rather commonly.  Unfortunately it does not resolve *all* the
> problems from recursive dependencies, but it does help keep them from
> exploding spontaneously quite so often.

On the same doc: 

% With respect to loading Exporter  and inheriting, there are alternatives
% with the use of modules like base  and parent .
% 
%   use base qw( Exporter );
%     # or
%   use parent qw( Exporter );

Which is the way i always used without knowing the problem, so i never
deal with @ISA or BEGIN. I just saw in the parent module doc that it
actually uses a BEGIN bloc as you do.

Thanks for your explainations.

I also saw that use vars is obsoleted by our
(http://search.cpan.org/~rgarcia/perl-5.10.0/pod/perlfunc.pod#our) 

So i write the code the way i always do:

use strict;
use parent 'Exporter';
our $VERSION = 3.01; 
our @EXPORT = qw(
        &GetBookSeller &GetBooksellersWithLateOrders &GetBookSellerFromId
        &ModBookseller &DelBookseller &AddBookseller
);

And it works fine but i admit that i don't know how to fix this bug the
way you want it to be fixed.

regards

-- 
Marc Chantreux
http://www.biblibre.com
Expert en Logiciels Libres pour l'info-doc



More information about the Koha-patches mailing list