[Koha-patches] [PATCH] Add the feature to create reports with borrower's sex information(Men/Women) (bug #2671).

Henri-Damien LAURENT henridamien at koha-fr.org
Tue Oct 14 17:54:38 CEST 2008


Joe Atzberger a écrit :
>
>
> On Tue, Oct 14, 2008 at 10:23 AM, Nahuel Angelinetti
> <nahuel.angelinetti at biblibre.com
> <mailto:nahuel.angelinetti at biblibre.com>> wrote:
>
>     ---
>     -               DHTMLcalendar_dateformat =>
>     C4::Dates->DHTMLcalendar(),
>     +               DHTMLcalendar_dateformat =>
>     C4::Dates->DHTMLcalendar('iso')
>
>
> I'm not sure, but I think this might cause trouble to those whose date
> format is not ISO.  Scripts should expect user-input dates received to
> be in the syspref format, "catching" them by instantiating C4::Dates
> objects (or at least using the Dates regexps). 
>
> The datefomat change is not described in your commit message and seems
> unrelated to it.  Perhaps you can resubmit without it, or explain your
> motivation?
>
> --Joe
Hi joe,
the problem here is that SQL expects ISO formatted dates and was
provided non iso.
So he solved it quick way.
And would not format input dates into iso from those provided by the page.
I agree with you.
Will resubmit a patch.
Cheers.
-- 
Henri-Damien LAURENT



More information about the Koha-patches mailing list