[Koha-patches] [PATCH] Markup corrections, style fixes, and other minor bugs, including fix for Bug 2679 ("Dates Changing on Funds When Editing")

[henridamien.laurent]

Owen Leonard a écrit :
> ---
>  acqui/neworderempty.pl                             |    1 -
>  admin/aqbudget.pl                                  |    4 +-
>  admin/authorised_values.pl                         |    1 -
>  .../prog/en/includes/authorities-search.inc        |   12 ++--
>  .../prog/en/includes/bookfund-admin-search.inc     |   10 +-
>  .../prog/en/includes/cities-admin-search.inc       |    4 +-
>  .../prog/en/includes/dictionary-toolbar.inc        |    2 +-
>  .../prog/en/includes/guided-reports-view.inc       |    8 +-
>  .../prog/en/includes/roadtype-admin-search.inc     |    4 +-
>  .../prog/en/modules/acqui/neworderempty.tmpl       |    6 +-
>  .../prog/en/modules/admin/aqbudget.tmpl            |    4 +-
>  .../prog/en/modules/admin/branches.tmpl            |   14 ++-
>  .../prog/en/modules/admin/currency.tmpl            |   10 ++-
>  .../prog/en/modules/admin/patron-attr-types.tmpl   |    2 +-
>  .../prog/en/modules/authorities/authorities.tmpl   |   31 +++-----
>  .../prog/en/modules/reports/borrowers_out.tmpl     |    2 +-
>  .../prog/en/modules/reports/cat_issues_top.tmpl    |    4 +-
>  .../en/modules/reports/guided_reports_start.tmpl   |    8 +-
>  .../prog/en/modules/reports/itemslost.tmpl         |    2 +-
>  .../prog/en/modules/serials/member-search.tmpl     |    6 +-
>  .../prog/en/modules/serials/routing.tmpl           |    8 +-
>  .../en/modules/serials/serials-collection.tmpl     |    2 +-
>  .../prog/en/modules/serials/subscription-add.tmpl  |   78 ++++++++++----------
>  .../en/modules/serials/subscription-detail.tmpl    |    4 +-
>  24 files changed, 112 insertions(+), 115 deletions(-)
>
> diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl
> index 1340543..8baa60b 100755
> --- a/acqui/neworderempty.pl
> +++ b/acqui/neworderempty.pl
> @@ -189,7 +189,6 @@ my $CGIbookfund = CGI::scrolling_list(
>      -default  => ($data->{'bookfundid'} ? $data->{'bookfundid'} : $select_bookfund[0]),
>      -labels   => \%select_bookfunds,
>  	#-size     => 1,
> -	-tabindex =>'',
>      -multiple => 0
>  );
>  
> diff --git a/admin/aqbudget.pl b/admin/aqbudget.pl
> index 5ad9e1e..fccedae 100755
> --- a/admin/aqbudget.pl
> +++ b/admin/aqbudget.pl
> @@ -168,8 +168,8 @@ SELECT branchcode,
>      $template->param(
>          dateformat => C4::Dates->new()->visual(),
>          aqbudgetid => $dataaqbudget->{'aqbudgetid'},
> -        startdate => $dataaqbudget->{'startdate'},
> -          enddate => $dataaqbudget->{'enddate'},
> +        startdate => format_date($dataaqbudget->{'startdate'}),
> +          enddate => format_date($dataaqbudget->{'enddate'}),
>          budgetamount => $dataaqbudget->{'budgetamount'},
>          branches => \@branches,
>      );
> diff --git a/admin/authorised_values.pl b/admin/authorised_values.pl
> index ee57abd..a183c8f 100755
> --- a/admin/authorised_values.pl
> +++ b/admin/authorised_values.pl
> @@ -227,7 +227,6 @@ sub default_form {
>  			-values=> \@category_list,
>  			-default=>"",
>  			-size=>1,
> - 			-tabindex=>'',
>  			-multiple=>0,
>  			);
>  	if (!$searchfield) {
> diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc
> index 1aa10a2..adc09ad 100644
> --- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc
> +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc
> @@ -3,11 +3,11 @@
>  <div id="header_search" class="residentsearch">
>      <div id="authority_search" class="residentsearch">
>      <p class="tip">Enter authority heading ($a):</p>
> -    <form name="f" action="/cgi-bin/koha/authorities/authorities-home.pl" method="get">
> +    <form action="/cgi-bin/koha/authorities/authorities-home.pl" method="get">
>          <input type="hidden" name="op" value="do_search" />
>          <input type="hidden" name="type" value="intranet" />
>          <input type="hidden" name="nbstatements" value="<!-- TMPL_VAR NAME="nbstatements" -->" />
> -        <select id="authtypecode" name="authtypecode">
> +        <select name="authtypecode">
>          <!-- TMPL_LOOP NAME="authtypesloop" -->
>              <!-- TMPL_IF name="selected" -->
>              <option value="<!-- TMPL_VAR NAME="value" -->" selected="selected"><!-- TMPL_VAR NAME="authtypetext" --></option>
> @@ -33,11 +33,11 @@
>      </div>
>      <div id="main_heading" class="residentsearch" style="display:none;">
>      <p class="tip">Enter authority heading:</p>
> -    <form name="f" action="/cgi-bin/koha/authorities/authorities-home.pl" method="get">
> +    <form action="/cgi-bin/koha/authorities/authorities-home.pl" method="get">
>          <input type="hidden" name="op" value="do_search" />
>          <input type="hidden" name="type" value="intranet" />
>          <input type="hidden" name="nbstatements" value="<!-- TMPL_VAR NAME="nbstatements" -->" />
> -        <select id="authtypecode" name="authtypecode">
> +        <select  name="authtypecode">
>          <!-- TMPL_LOOP NAME="authtypesloop" -->
>              <!-- TMPL_IF name="selected" -->
>              <option value="<!-- TMPL_VAR NAME="value" -->" selected="selected"><!-- TMPL_VAR NAME="authtypetext" --></option>
> @@ -65,11 +65,11 @@
>      </div>
>      <div id="all_headings" class="residentsearch" style="display:none;">
>      <p class="tip">Enter any authority field:</p>
> -    <form name="f" action="/cgi-bin/koha/authorities/authorities-home.pl" method="get">
> +    <form action="/cgi-bin/koha/authorities/authorities-home.pl" method="get">
>          <input type="hidden" name="op" value="do_search" />
>          <input type="hidden" name="type" value="intranet" />
>          <input type="hidden" name="nbstatements" value="<!-- TMPL_VAR NAME="nbstatements" -->" />
> -        <select id="authtypecode" name="authtypecode">
> +        <select name="authtypecode">
>          <!-- TMPL_LOOP NAME="authtypesloop" -->
>              <!-- TMPL_IF name="selected" -->
>              <option value="<!-- TMPL_VAR NAME="value" -->" selected="selected"><!-- TMPL_VAR NAME="authtypetext" --></option>
>   

as far as I know, some js are requiring named forms.
Have you tested that value_builder still worked ?
Friendly.