[Koha-patches] [PATCH] fix calls to get_template_and_user in label-item-search.pl

[Galen Charlton]

Hi,

I checked, and I don't see debug being passed to HTML::Template::Pro
either (nor do I think it would be a good idea to set debug => 1 all
the time, because it would apparently dump a lot of random debugging
information in the Apache log),

Michael, please resubmit the patch with debug => 1 to match the usual
convention, but I would not be entirely surprised if we end up doing a
global s/debug => 1/debug => $debug/.

Regards,

Galen

On Tue, Oct 7, 2008 at 3:50 PM, Michael Hafen <mdhafen at tech.washk12.org> wrote:
> I didn't see that.  I've checked again too.  I don't see anywhere in
> C4::Auth::get_template_and_user() where $in->{debug} is referenced
> either directly or indirectly.
>
> On Tue, 2008-10-07 at 15:39 -0400, Joe Atzberger wrote:
>> I think it ends up being passed directly to HTML::Template::Pro.
>>
>> On Tue, Oct 7, 2008 at 3:35 PM, Michael Hafen
>> <mdhafen at tech.washk12.org> wrote:
>>         Yeah, I should have researched that first.  Sorry.
>>
>>         I've looked at Auth.pm now, and I don't see this debug => 1
>>         being used
>>         anywhere in there.  Could this be left over from older code?
>>          If it is
>>         I'll happily re-post this patch without the debug => 1.
>>
>>         Thanks.
>>
>>
>>         On Tue, 2008-10-07 at 15:22 -0400, Joe Atzberger wrote:
>>         > Don't get confused by the different debug params.  My
>>         understanding is
>>         > that as far as the templating is concerned, we always pass
>>         debug=>1 to
>>         > get_template_and_user.  We don't want that value to be
>>         linked to
>>         > C4::Debug's $debug or any other $debug.
>>         >
>>         > --joe
>>         >
>
>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>



-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt