[Koha-patches] [PATCH] debugify a warn

[Galen Charlton]

Hi,

On Thu, Oct 16, 2008 at 12:07 PM, Joe Atzberger
<joe.atzberger at liblime.com> wrote:
> In my opinion that condition is deserving of a warning in the log and should
> not be conditional on $debug.  It is not like the warns in regularly
> processed blocks that were clearly intended for temporary debugging.  This
> one is a sanity check against *internal* error.  You can see it is regarded
> as more serious than the other user-input problems pushed to @errors.

The problem is it currently splatters the warning in the log whenever
a user accidentally tries to add a duplicate tag to a bib, a
conditional which is neither an internal error nor worthy of spamming
the Apache log.  Refactor the code so that it doesn't treat user error
like an internal error and the warn can be undebugified.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt