[Koha-patches] [PATCH] Report to user the connections

paul POULAIN paul.poulain at biblibre.com
Fri Oct 17 09:51:22 CEST 2008


Nahuel ANGELINETTI a écrit :
> I just resend, this patch was for 3.0.x, I done another for HEAD.
>   
Great job, but just a possible improvement : could you give more details 
in the commit notes.
For this one, I would have written :
"
Better handling of "no result" on z3950 searches

Report to user the connections errors to z39.50 server, like 
timeout(10007), and refused(10000).

Before this patch, the user just got a "no answer", and he don't know if 
it means there is 0 results to your query or the server did not respond. 
Now he got a different message, depending on why there is no result
"

cheers.

Git way of writing patches : the 1st line of your comment the summary 
and is everywhere. It should not be more than 80 char (patch name, logs, 
...)
then, an empty line
then the detail of your patch

-- 
Paul POULAIN
http://www.biblibre.com
Expert en Logiciels Libres pour l'info-doc
NOUVEAU TELEPHONE : 04 91 81 35 08




More information about the Koha-patches mailing list