[Koha-patches] [PATCH] Move basic editing to main system preferences screen

[Galen Charlton]

Hi,

On Tue, Sep 23, 2008 at 8:27 PM, Jesse Weaver <jesse.weaver at liblime.com> wrote:
> From: Pianohacker <pianohacker at gmail.com>
>
> This allows the user to edit system preferences from the main system
> preferences table. It also updates many preferences' display properties to work
> correctly in this new system.
> ---
>  admin/systempreferences.pl                         |  267 ++++++++++----------
>  installer/data/mysql/updatedatabase.pl             |   29 +++
>  .../intranet-tmpl/prog/en/css/staff-global.css     |    4 +
>  .../prog/en/modules/admin/systempreferences.tmpl   |  124 ++++++++--
>  kohaversion.pl                                     |    2 +-
>  5 files changed, 278 insertions(+), 148 deletions(-)

Nearly there, but it needs some work:

1. This patch breaks the system preference search.

2. When you click to go the edit page for a system preference, the
variable type and options are no longer filled in.

3. Changes that you make to syspref definitions in updatedatabase.pl
also need to be made in the English and French syspref SQL scripts.

4. There's an unconditional warn whenever a preference is changed:

Modding libraryAddress at ...

5. method="POST" should be method="post" for XHTML compliance.

6. Neither the textareas nor the click to edit links for them are
showing, probably because of use of the content_hidden class.  Please
use display: none instead.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt