[Koha-patches] [PATCH] add the possibility to replace, in sysprefs, the code by it's valuecode with {{code}}

[Galen Charlton]

Hi,

I'm rejecting this patch for now -

1. The patch description needs improvement - it doesn't identify which
syspref it's talking about, it doesn't make it clear that it's talking
about the ISBD display, and there really ought to be an example of
what the patch is trying to accomplish.

2. This patch changes opac-ISBDdetail.pl, but doesn't change
catalogue/ISBDdetail.pl, even though the ISBD display logic is
virtually identical.

3. In fact, the logic that generates the ISBD display really ought to
be factored into a common routine that's referred to by both the staff
and OPAC scripts.

Regards,

Galen

On Mon, Oct 13, 2008 at 5:49 AM, Nahuel Angelinetti
<nahuel.angelinetti at biblibre.com> wrote:
> ---
>  opac/opac-ISBDdetail.pl |   12 ++++++++++--
>  1 files changed, 10 insertions(+), 2 deletions(-)


-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt