[Koha-patches] [PATCH] Squash warnings by checking if $type is defined before comparing it.
Joe Atzberger
joe.atzberger at liblime.com
Thu Oct 30 06:10:57 CET 2008
---
C4/Members.pm | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/C4/Members.pm b/C4/Members.pm
index e756ffb..7ee9eb3 100644
--- a/C4/Members.pm
+++ b/C4/Members.pm
@@ -527,7 +527,7 @@ SELECT borrowers.*, categories.category_type, categories.description
FROM borrowers
LEFT JOIN categories on borrowers.categorycode=categories.categorycode
";
- if ( defined $type && ( $type eq 'cardnumber' || $type eq 'firstname'|| $type eq 'userid'|| $type eq 'borrowernumber' ) ){
+ if (defined($type) and ( $type eq 'cardnumber' || $type eq 'firstname'|| $type eq 'userid'|| $type eq 'borrowernumber' ) ){
$information = uc $information;
$sth = $dbh->prepare("$select WHERE $type=?");
} else {
@@ -535,14 +535,12 @@ LEFT JOIN categories on borrowers.categorycode=categories.categorycode
}
$sth->execute($information);
my $data = $sth->fetchrow_hashref;
- $sth->finish;
($data) and return ($data);
- if ($type eq 'cardnumber' || $type eq 'firstname') { # otherwise, try with firstname
+ if (defined($type) and ($type eq 'cardnumber' || $type eq 'firstname')) { # otherwise, try with firstname
$sth = $dbh->prepare("$select WHERE firstname like ?");
$sth->execute($information);
$data = $sth->fetchrow_hashref;
- $sth->finish;
($data) and return ($data);
}
return undef;
--
1.5.5.GIT
More information about the Koha-patches
mailing list