[Koha-patches] [PATCH] Bugfix bug #2630

Galen Charlton galen.charlton at liblime.com
Fri Sep 26 16:20:23 CEST 2008


Hi,

On Mon, Sep 22, 2008 at 12:49 PM, Frederic Demians <f.demians at tamil.fr> wrote:
> -        my $aisbn = $oldbiblio->{'isbn'};
> -        $aisbn =~ /(\d*[X]*)/;
> -        $oldbiblio->{amazonisbn} = $1;
> +        ($_) = $oldbiblio->{isbn} =~ /([\d-]*[X]*)/;
> +        s/-//g;

Why are you assigning to $_?  There's no need to do that, since $foo
=~ s/-//g works perfectly well.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt



More information about the Koha-patches mailing list