[Koha-patches] [PATCH 2/2] Internationalize Amazon support

[Galen Charlton]

Hi,

I am rejecting this patch - please see below.  Note that I will be
pushing the first of your Amazon patches, the one that tweaks the ISBN
normalization.

2009/3/30 Frédéric Demians <f.demians at tamil.fr>:

> --- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
> +++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
> @@ -52,7 +52,13 @@
>     <div id="catalogue_detail_biblio">
>
>     <div id="bookcover">
> -    <!-- TMPL_IF NAME="OPACAmazonEnabled" --><!-- TMPL_IF NAME="OPACAmazonCoverImages" --><!-- TMPL_IF NAME="OPACURLOpenInNewWindow" --><a href="http://www.amazon.com/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" -->/ref=sib_dp_pt/002-7879865-0184864#reader-link" target="_blank"><img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR NAME="normalized_isbn" -->.01._PIdp-schmooS,TopRight,7,-26_SCMZZZZZZZ_.jpg" alt="Cover Image" /></a><!-- TMPL_ELSE --><a href="http://www.amazon.com/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" -->/ref=sib_dp_pt/002-7879865-0184864#reader-link"><img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR NAME="normalized_isbn" -->.01._PIdp-schmooS,TopRight,7,-26_SCMZZZZZZZ_.jpg" alt="Cover Image" /></a><!-- /TMPL_IF --><!-- /TMPL_IF --><!-- /TMPL_IF -->
> +<!-- TMPL_IF NAME="OPACAmazonEnabled" -->
> +<!-- TMPL_IF NAME="OPACAmazonCoverImages" -->
> +<a href="http://www.amazon<!-- TMPL_VAR NAME="AmazonTld" -->/gp/reader/<!-- TMPL_VAR NAME="normalized_isbn" -->/ref=sib_dp_pt/002-7879865-0184864#reader-link"
> +<!-- TMPL_IF NAME="OPACURLOpenInNewWindow" -->target="_blank"><!-- /TMPL_IF -->
> +<img border="0" src="http://images.amazon.com/images/P/<!-- TMPL_VAR NAME="normalized_isbn" -->.01.MZZZZZZZ.jpg" alt="Cover Image" />
> +</a>
> +<!-- /TMPL_IF -->

There are a couple problem with this change:

* One of the TMPL_IF is not closed, leading to an OPAC details display
that is truncated after the bookcover div.
* The change to the OPACURLOpenInNewWindow logic will  result in
invalid XHTML if the syspref is off:

<a href="foo" <img .../></a>

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt