[Koha-patches] [PATCH] batchRepairBiblionumbers was using an outdated table :
Galen Charlton
galen.charlton at liblime.com
Sat Apr 18 18:22:01 CEST 2009
Hi,
On Sat, Apr 18, 2009 at 10:57 AM, Nahuel ANGELINETTI
<nahuel.angelinetti at biblibre.com> wrote:
> From: Henri-Damien LAURENT <henridamien.laurent at biblibre.com>
It would be better to replace much of the code added by this patch
with a call to C4::Biblio::_koha_marc_update_bib_ids(). This will
avoid copy and paste and work better: see below:
> + if ($tag>010){
This condition is wrong in two different ways:
1. "010" is an *octal* literal, so has value 8.
2. MARC tag 010 can have subfields, so the condition should be $tag >= 10.
Regards,
Galen
--
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt
More information about the Koha-patches
mailing list