[Koha-patches] [PATCH] Minor tuning of opac-reserve

[Galen Charlton]

Hi,

On Tue, Mar 24, 2009 at 5:38 PM, Joe Atzberger
<joe.atzberger at liblime.com> wrote:
>  ~ Allow failover to default value if maxreserves not defined.  The
> default is taken from the English sysprefs (50), not the French (2).
> Note that this means users cannot "disable" reserves by setting
> maxreserves = 0, but that is BY DESIGN, since there is a separate
> syspref for that purpose.

This is inviting the inevitable support question - "why is it allowing
hold requests when I've set maxreserves to 0".  The applicable
principle here is the one of least surprise; while we *could* say "go
look at this other syspref", letting the Koha admin just set
maxreserves to 0 prevents the question from being asked in the first
place.

> +my $MAXIMUM_NUMBER_OF_RESERVES = C4::Context->preference("maxreserves") || 50;

Consequently, a more verbose test is needed.  Default to 50 if the
syspref value is undef or blank, but let value 0 *be* value zero.

Other than that, the rest of the patch appears pushable to HEAD.
Please change and resubmit.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt