[Koha-patches] [PATCH] New feature Number of Returned Items to Show

Galen Charlton galen.charlton at liblime.com
Fri Apr 24 19:45:34 CEST 2009


Hi,

On Fri, Apr 24, 2009 at 1:43 PM, Michael Hafen <mdhafen at tech.washk12.org> wrote:
> Hmm, you're right.  I didn't look into that loop far enough.  Though
> this begs the question: why is there a limit on the number of items you
> can check in?  That hard coded limit of 20 suddenly seems out of place
> to me.  Unless it's to protect against D.O.S. attacks on this script.
> But that loop is after the call to get_template_and_user() so that isn't
> the case.

Yeah, that hard-coded limit looks out of place to me too.  I can
imagine a point where you wouldn't want to try to return 10,000 items
at once, but I'm pretty sure that 20 is too low.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt



More information about the Koha-patches mailing list