[Koha-patches] [PATCH] bug 2915 followup - small efficiency improvement

Galen Charlton galen.charlton at liblime.com
Mon Apr 27 17:31:03 CEST 2009


Following up on a suggestion by Joe Atzberger, save
a database query by not counting the subscriptions
to delete; instead, simply fetch a list of them.

No user-visible change.
---
 C4/Biblio.pm |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/C4/Biblio.pm b/C4/Biblio.pm
index de0b3c3..0a702a3 100644
--- a/C4/Biblio.pm
+++ b/C4/Biblio.pm
@@ -379,11 +379,9 @@ sub DelBiblio {
     return $error if $error;
 
     # We delete attached subscriptions
-    if(C4::Serials::CountSubscriptionFromBiblionumber($biblionumber) != 0){
-        my $subscriptions = &C4::Serials::GetFullSubscriptionsFromBiblionumber($biblionumber);
-        foreach my $subscription (@$subscriptions){
-            &C4::Serials::DelSubscription($subscription->{subscriptionid});
-        }
+    my $subscriptions = &C4::Serials::GetFullSubscriptionsFromBiblionumber($biblionumber);
+    foreach my $subscription (@$subscriptions){
+        &C4::Serials::DelSubscription($subscription->{subscriptionid});
     }
     
     # Delete in Zebra. Be careful NOT to move this line after _koha_delete_biblio
-- 
1.5.6.5




More information about the Koha-patches mailing list