[Koha-patches] [PATCH] Revisions to auto-generated authorities patch

[Galen Charlton]

Hi,

On Mon, Apr 27, 2009 at 1:15 PM, Brian Harrington <brian at jhu.edu> wrote:
> I can certainly revise things and put the SetMarcUnicodeFlag call back
> in immediately after MARC::Record->new().  I guess my question would be
> whether setting the MARC::Record->encoding() there actually has any
> impact on add_subfields and similar calls.  A quick glance at the code
> made me think that it didn't, but I'm still a very much newbie here.

The problems with an incorrect value for the Leader/09 arise when
*parsing* a MARC record.  It is not necessary to call
SetMarcUnicodeFlag immediately after initializing a new record,
particularly if you end up setting its leader, but to be absolutely
sure that sure that there are no problems, it would be a good idea to
ensure that it is called before the function ends or the record is
passed to any other function.  To sum up, I suggest the following
sequence for BiblioAddAuthorities():

1. MARC::Record->new()
2. Set leader
3. SetMarcUnicodeFlag.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt