[Koha-patches] [PATCH] Bug 3173 Place Hold link visible in OPAC even if syspref turned off

[Wagner, Jane]

I've reworked & resent.  There are some really odd nests in those
templates....

 

Thanks.

 

Jane Wagner

Library Systems Analyst

PTFS Inc.

Content Management and Library Solutions

6400 Goldsboro Road, Suite 200

Bethesda, MD  20817

(301) 654-8088 x 151

jwagner at ptfs.com

 

From: Joe Atzberger [mailto:joe.atzberger at liblime.com] 
Sent: Wednesday, April 29, 2009 6:48 PM
To: Wagner, Jane
Cc: patches at koha.org
Subject: Re: [Koha-patches] [PATCH] Bug 3173 Place Hold link visible in
OPAC even if syspref turned off

 

Jane --

	When I added the TMPL_VAR statements into the various .tmpl
files, I definitely added a closing TMPL_IF statement for each one.
I'm positive of that because I was doing them in pairs. 

If you did, it wasn't part of the same commit from which this patch was
generated.  

You can see in this notation:

diff --git a/koha-tmpl/opac-tmpl/prog/en/

modules/opac-results.tmpl
b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tmpl
index 60c7858..e7e4ec1 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tmpl
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tmpl
@@ -279,9 +279,10 @@ $(document).ready(function(){
            <!-- TMPL_IF EXPR="opacbookbag || virtualshelves" -->
               <span class="addto"></span>
            <!-- /TMPL_IF -->
+               <!-- TMPL_IF NAME="opacuserlogin" --><!-- TMPL_IF
NAME="RequestOnOpac" -->
                   <span id="placehold"><!-- input class="submit"
type="submit" value="Place Hold"/ --></span>
            <div id="holdDetails"></div>
-
+            <!-- /TMPL_IF -->
                       <!-- TMPL_IF NAME="TagsEnabled" -->
            <!-- TMPL_IF NAME="TagsInputOnList" -->
                <span id="tagsel_span"></span>



Two TMPL_IF get added, but only one /TMPL_IF.  
-- 
Joe Atzberger
LibLime - Open Source Library Solutions

-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-patches/attachments/20090430/8d7fc3b6/attachment-0002.htm>