[Koha-patches] [PATCH] Bug 3466: Fixes xhtml errors in shelves.tmpl.

Garry Collum gcollum at gmail.com
Sun Aug 2 02:17:27 CEST 2009


The errors show up when you are viewing the public tab of the lists page.
A closed <form> element (<form />).
A table row not associated with a table.
---
 .../prog/en/modules/virtualshelves/shelves.tmpl    |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tmpl
index b5b9afd..f00399a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tmpl
@@ -309,8 +309,9 @@ function placeHold () {
 		<!-- TMPL_ELSE -->
 		<div id="privateshelves" class="ui-tabs-panel" style="display:none;">
 		<!-- /TMPL_IF -->
-            <!-- TMPL_IF NAME="shelveslooppriv" -->
+            <!-- TMPL_IF NAME="showprivateshelves" -->
 			<!-- TMPL_VAR name='pagination_bar'-->
+            <!-- TMPL_IF NAME="shelveslooppriv" -->
         		<table>
         		<tr><th>List Name</th><th>Contents</th><th>Sort by</th><th>Type</th><th>Options</th></tr>
                 <!-- TMPL_LOOP NAME="shelveslooppriv" -->
@@ -346,10 +347,11 @@ function placeHold () {
 		</td>
 		</tr>
                 <!-- /TMPL_LOOP -->
+            </table>
             <!-- TMPL_ELSE -->
-            <tr><td colspan="4">No Private Lists.</td></tr>
+            No Private Lists.
             <!-- /TMPL_IF --><!-- /shelveslooppriv -->
-        </table>
+        <!-- /TMPL_IF --><!-- /showprivateshelves -->
 		</div><!-- /privateshelves -->
 
         <!-- TMPL_IF NAME="showpublicshelves" -->
@@ -362,7 +364,7 @@ function placeHold () {
         <table>
         <tr><th>List Name</th><th>Contents</th><th>Sort By</th><th>Type</th><th>Options</th></tr>
             <!-- TMPL_LOOP NAME="shelvesloop" -->
-                <!-- TMPL_UNLESS NAME="__odd__" --><tr class="highlight"><!--TMPL_ELSE--><tr><!-- /TMPL_UNLESS -->
+                <!-- TMPL_UNLESS NAME="__odd__" --><tr class="highlight"><!-- TMPL_ELSE --><tr><!-- /TMPL_UNLESS -->
 		<td><a href="shelves.pl?viewshelf=<!-- TMPL_VAR NAME="shelf" -->"><!-- TMPL_VAR NAME="shelfname" ESCAPE="html"  --></a></td>
 		<td><!-- TMPL_VAR NAME="count" --> item(s)</td>
         <td><!-- TMPL_VAR NAME="sortfield" --></td>
@@ -401,7 +403,7 @@ function placeHold () {
 		</div>
 <!-- /TMPL_UNLESS -->
 
-<form id="hold_form" method="get" action="/cgi-bin/koha/reserve/request.pl"/>
+<form id="hold_form" method="get" action="/cgi-bin/koha/reserve/request.pl">
     <!-- Value will be set here by placeHold() -->
     <input id="hold_form_biblios" type="hidden" name="biblionumbers" value="" />
     <input type="hidden" name="multi_hold" value="1"/>
-- 
1.5.6.5




More information about the Koha-patches mailing list