[Koha-patches] [PATCH] Bug 3420: Follow-up patch for 'patrons with no checkouts'
Garry Collum
gcollum at gmail.com
Sat Aug 15 22:24:08 CEST 2009
Comments out all warnings that were used for debugging.
Enables warnings and fixes all resulting warnings.
---
reports/borrowers_out.pl | 24 ++++++++++++++----------
1 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/reports/borrowers_out.pl b/reports/borrowers_out.pl
index 2bd831b..b441156 100755
--- a/reports/borrowers_out.pl
+++ b/reports/borrowers_out.pl
@@ -18,6 +18,8 @@
# Suite 330, Boston, MA 02111-1307 USA
use strict;
+use warnings;
+
use CGI;
use C4::Auth;
use C4::Context;
@@ -47,7 +49,7 @@ my @filters = $input->param("Filter");
my $output = $input->param("output");
my $basename = $input->param("basename");
my $mime = $input->param("MIME");
-our $sep = $input->param("sep");
+our $sep = $input->param("sep") || '';
$sep = "\t" if ($sep eq 'tabulation');
my ($template, $borrowernumber, $cookie)
= get_template_and_user({template_name => $fullreportname,
@@ -88,9 +90,9 @@ if ($do_it) {
my $x = $line->{loopcell};
print $line->{rowtitle}.$sep;
foreach my $cell (@$x) {
- print $cell->{value}.$sep;
+ print $cell->{value}.$sep if $cell->{value};
}
- print $line->{totalrow};
+# print $line->{totalrow};
print "\n";
}
# footer
@@ -190,7 +192,7 @@ sub calculate {
}
$strsth2 .=" group by $colfield";
$strsth2 .=" order by $colorder";
- warn "". $strsth2;
+ # warn "". $strsth2;
my $sth2 = $dbh->prepare( $strsth2 );
$sth2->execute;
@@ -213,10 +215,11 @@ sub calculate {
my @table;
# warn "init table";
- for (my $i=1;$i<=$line;$i++) {
- foreach my $col ( @loopcol ) {
-# warn " init table : $row->{rowtitle} / $col->{coltitle} ";
- $table[$i]->{($col->{coltitle})?$col->{coltitle}:"Global"}=0;
+ if($line) {
+ for (my $i=1;$i<=$line;$i++) {
+ foreach my $col ( @loopcol ) {
+ $table[$i]->{($col->{coltitle})?$col->{coltitle}:"Global"}=0;
+ }
}
}
@@ -254,10 +257,10 @@ sub calculate {
$strcalc .= " order by $colfield " if ($colfield);
my $max;
if (@loopcol) {
- $max = $line*@loopcol;
+ $max = $line*@loopcol if $line;
} else { $max=$line;}
$strcalc .= " LIMIT 0,$max" if ($line);
- warn "SQL :". $strcalc;
+# warn "SQL :". $strcalc;
my $dbcalc = $dbh->prepare($strcalc);
$dbcalc->execute;
@@ -313,3 +316,4 @@ sub calculate {
}
1;
+__END__
--
1.5.6.5
More information about the Koha-patches
mailing list