[Koha-patches] [PATCH] Bug fix 3409 : Adding an internal function to C4::Circulation

[Galen Charlton]

Hi,

On Thu, Aug 13, 2009 at 8:58 AM, Henri-Damien
LAURENT<henridamien.laurent at biblibre.com> wrote:

> -        # the holdingbranch is updated if the document is returned to another location.
> -        if ($item->{'holdingbranch'} ne $branch) {
> -            UpdateHoldingbranch($branch, $item->{'itemnumber'});
> -            $item->{'holdingbranch'} = $branch; # update item data holdingbranch too
> -        }
> +
> +
> +        # We update the holdingbranch from circControlBranch variable
> +        UpdateHoldingbranch($circControlBranch,$item->{'itemnumber'});
> +        $item->{'holdingbranch'} = $circControlBranch;
> +
> +

If an item is checked in at library A, should not the item's current
holding branch, i.e., where the item was actually last seen, always be
set to library A, not to library B (the returning patron's home
library), library C (the item's current home library) or library D
(the item's current holding library, depending on the
HomeOrHoldingBranch syspref)?  If you believe that it should actually
be set to the circ control library, please explain why.  The bug
description in 3409 is not very clear to me.  If you mean for the circ
control library to use used in the library transfer rule lookup,
please use it explicitly, don't overload $item->{holdingbranch}.

I am going to push this patch but immediately follow up with one
reverting the section I've highlighted above until we can straighten
this out.

+1 for _GetCirculationBranch.

Regards,

Galen
-- 
Galen Charlton
gmcharlt at gmail.com