[Koha-patches] [PATCH] [3.0.x][followup](bug #3173) revert non-working code

Nahuel ANGELINETTI nahuel.angelinetti at biblibre.com
Wed Dec 9 16:44:44 CET 2009


This patch revert 2 functions in OPAC shelves :
 * Add tags on shelf records
 * make hold on shelf records

The deleted code was backported from HEAD, but cannot be implemented as this in 3.0.x because API doesn't support it.
New feature must not be added to 3.0.x, or at least support the good API.
---
 .../opac-tmpl/prog/en/modules/opac-shelves.tmpl    |   38 +-------------------
 1 files changed, 1 insertions(+), 37 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tmpl
index 1487d14..a6de2d3 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tmpl
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tmpl
@@ -9,21 +9,6 @@ $.tablesorter.addParser({
     format: function(s) { return s.toLowerCase().replace(/^(the|an|a) /,''); }, 
     type: 'text' 
 });
-function holdSelections() {
-    var checkedBoxes = $(":checkbox:checked");
-    if ($(checkedBoxes).size() == 0) {
-        alert(MSG_NO_RECORD_SELECTED);
-    } else {
-        var bibs = "";
-        $(checkedBoxes).each(function(){
-            var name = $(this).attr("name");
-            bib = name.substr(4);
-            bibs += bib + "/";
-        });
-        document.location = "/cgi-bin/koha/opac-reserve.pl?biblionumbers="+bibs;
-    }
-}
-
 
 $(function() {
     $("span.clearall").html("<a id=\"CheckNone\" href=\"#\">"+_("Clear All")+"</a>");
@@ -47,17 +32,9 @@ $(function() {
         $(".checkboxed").unCheckCheckboxes();
         return false;
     });
-});
 
-$(document).ready(function(){
-    <!-- TMPL_IF NAME="TagsEnabled" -->
-    $("#tagsel_tag").text("Tag");
-    $("#tagsel_button").click(function(){
-        tagAdded();
-        return false;
-    });
-    <!-- /TMPL_IF -->
 });
+
 //]]>
 </script>
 </head>
@@ -133,19 +110,6 @@ $(document).ready(function(){
                          <input type="submit" class="deleteshelf" value="Delete List" onclick="return confirmDelete(_('Are you sure you want to remove this List?'));"/>
                       </form>
        <!-- /TMPL_IF -->
-                      <a href="#" class="send tag_hides" onclick="open(CGIBIN+'opac-sendshelf.pl?shelfid=<!-- TMPL_VAR NAME="shelfnumber" -->','win_form','dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100')">Send List</a>
-					<!-- TMPL_IF NAME="RequestOnOpac" -->
-                      <a href="#" class="hold tag_hides" onclick="holdSelections();return false;"></a>
-					<!-- /TMPL_IF -->
-                    <!-- /div -->
-                    <a id="tagsel_tag" href="#" onclick="tagSelected(); return false;"></a>                 
-                    <span id="tagsel_form" style="display:none">
-                      <label for="tagsel_new" style="display:inline">New&nbsp;Tag:</label>
-                      <input name="tagsel_new" id="tagsel_new" maxlength="100" style="display:inline"/>
-                      <input id="tagsel_button" name="tagsel_button" class="input tagsel_button" title="tagsel_button"
-                             type="submit" value="Add" style="display:inline" />
-                      <a href="#" id="tagsel_cancel" onclick="tagCanceled(); return false;" style="display:inline">Cancel</a>
-                    </span>
                   </div>
                 <!-- TMPL_IF NAME="manageshelf" -->
                   <form action="/cgi-bin/koha/opac-shelves.pl" method="post" name="myform" class="checkboxed">
-- 
1.6.3.3




More information about the Koha-patches mailing list