[Koha-patches] [PATCH] Remove diagnostic output from t/Members_Attributes.t

Jesse Weaver pianohacker at gmail.com
Tue Dec 15 07:12:48 CET 2009


While this might be useful for developers, is mostly pointless
otherwise. Should be replaced with a true test of these four
functions.
---
 t/Members_Attributes.t |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/t/Members_Attributes.t b/t/Members_Attributes.t
index a60a988..aafd9a9 100755
--- a/t/Members_Attributes.t
+++ b/t/Members_Attributes.t
@@ -94,17 +94,11 @@ can_ok('C4::Members::Attributes', qw(extended_attributes_merge extended_attribut
 
 ok(ref($C4::Members::Attributes::AttributeTypes) eq 'HASH', '$C4::Members::Attributes::AttributeTypes is a hashref');
 
-diag scalar(@merge_tests) . " tests for extended_attributes_merge";
-
 foreach my $test (@merge_tests) {
     my ($old, $new, $merged);
     ok($old = extended_attributes_code_value_arrayref($test->{line1}), "extended_attributes_code_value_arrayref('$test->{line1}')");
-    foreach (@$old) { diag "old attribute: $_->{code} = $_->{value}"; }
     ok($new = extended_attributes_code_value_arrayref($test->{line2}), "extended_attributes_code_value_arrayref('$test->{line2}')");
-    foreach (@$new) { diag "new attribute: $_->{code} = $_->{value}"; }
     ok($merged = extended_attributes_merge($old, $new),                "extended_attributes_merge(\$old, \$new)");
-    foreach (@$merged) { diag "merge (overwrite) attribute: $_->{code} = $_->{value}"; }
     ok($merged = extended_attributes_merge($old, $new, 1),             "extended_attributes_merge(\$old, \$new, 1)");
-    foreach (@$merged) { diag "merge (preserve) attribute: $_->{code} = $_->{value}"; }
 }
 
-- 
1.6.5.5




More information about the Koha-patches mailing list