[Koha-patches] [PATCH] Fix for Bug 3939, Issuing rules clone button looks like a submit

Owen Leonard oleonard at myacpl.org
Wed Dec 16 18:32:54 CET 2009


This patch incorporates a drop-down for choosing the "clone to" library
directly from issuing-rules.pl. This eliminates the extra step of choosing
the library after submitting the "clone" action and clarifies the purpose
of the two different controls.
---
 .../prog/en/modules/admin/smart-rules.tmpl         |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tmpl
index 2811399..ed81a9b 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tmpl
@@ -47,8 +47,8 @@ $(document).ready(function() {
         <p>To modify a rule, create a new one with the same patron type and item type.</p>
     </div>
     <div id="bloc100">
-        <form method="get" action="/cgi-bin/koha/admin/smart-rules.pl" id="selectlibrary">
-        Select a library :
+        <fieldset><form method="get" action="/cgi-bin/koha/admin/smart-rules.pl" id="selectlibrary">
+        <label for="branch"><strong>Edit issuing rules for:</strong></label>
             <select name="branch" id="branch" style="width:20em;">
                 <option value="*">Default</option>
             <!-- TMPL_LOOP NAME="branchloop" -->
@@ -56,9 +56,9 @@ $(document).ready(function() {
             <!-- /TMPL_LOOP -->
             </select>
         </form>
- 	<!-- TMPL_IF Name="definedbranch" --><form action="/cgi-bin/koha/admin/clone-rules.pl" method="post"><input type="hidden" name="frombranch" value="<!-- TMPL_VAR NAME="branch" -->" /><input type="submit" value="Clone these rules" /></form><!-- /TMPL_IF -->
-		<br />
-		<br />
+<!-- TMPL_IF Name="definedbranch" --><form action="/cgi-bin/koha/admin/clone-rules.pl" method="post"><label for="tobranch"><strong>Clone these rules to:</strong></label> <input type="hidden" name="frombranch" value="<!-- TMPL_VAR NAME="branch" -->" /> 
+            <select name="tobranch" id="tobranch"><!-- TMPL_LOOP NAME="branchloop" --><option value="<!-- TMPL_VAR NAME="value" -->"><!-- TMPL_VAR NAME="branchname" --></option><!-- /TMPL_LOOP --></select> <input type="submit" value="Clone" /></form><!-- /TMPL_IF --></fieldset>
+
         <form method="post" action="/cgi-bin/koha/admin/smart-rules.pl">
             <input type="hidden" name="op" value="add" />
             <table>
-- 
1.6.3.3




More information about the Koha-patches mailing list