[Koha-patches] [PATCH] patch for feature 2952

[Mason James]

On 2009/02/10, at 10:21 AM, Galen Charlton wrote:

> On Mon, Feb 9, 2009 at 4:14 PM, Mason James  
> <mason.loves.sushi at gmail.com> wrote:
>> On 2009/02/10, at 3:16 AM, Joe Atzberger wrote:
>>> Looks like you're missing a comma after "matched_biblionumber" in
>>> the field list.
> [snip]
>> nah, it is correct - and not a typo
>>
>> thanks for noticing it Joe
>
> I don't see any particular reason for aliasing matched_biblionumber to
> biblionumber in the query in GetImportBibliosRange().  Please resubmit
> the patch without that.
>


my reason for the alias was that 'matched_biblionumber' was already  
being used in the loop :/

but, on 2nd glance im wrong  - its *match_biblioumber* that is  
currently being used

see here... line 253
http://git.koha.org/cgi-bin/gitweb.cgi?p=Koha;a=blob;f=koha-tmpl/ 
intranet-tmpl/prog/en/modules/tools/manage-marc- 
import.tmpl;h=4387d21a1ab41f8001f0c926130de663fd830c65;hb=3.0.x#l253

2 var names that are close enough that i make a mistake already ;)

so if you are happy with co-existing matched_biblioumber/ 
match_biblioumber - ill resubmit as you ask

your call Galen