[Koha-patches] [PATCH] Prevent warning if intranetuserjs is already NULL/undefined.

Joe Atzberger joe.atzberger at liblime.com
Sat Jan 17 01:31:54 CET 2009


Warning would look like:
updatedatabase.pl: Use of uninitialized value in string eq
at /home/user/koha/installer/data/mysql/updatedatabase.pl line 2141.
---
 installer/data/mysql/updatedatabase.pl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
index dc8a610..86ea1ea 100755
--- a/installer/data/mysql/updatedatabase.pl
+++ b/installer/data/mysql/updatedatabase.pl
@@ -2138,7 +2138,7 @@ if ( C4::Context->preference('Version') < TransformToNum($DBversion) ) {
     my $bad_value = "function prepareEmailPopup(){\r\n  if (!document.getElementById) return false;\r\n  if (!document.getElementById('reserveemail')) return false;\r\n  rsvlink = document.getElementById('reserveemail');\r\n  rsvlink.onclick = function() {\r\n      doReservePopup();\r\n      return false;\r\n	}\r\n}\r\n\r\nfunction doReservePopup(){\r\n}\r\n\r\nfunction prepareReserveList(){\r\n}\r\n\r\naddLoadEvent(prepareEmailPopup);\r\naddLoadEvent(prepareReserveList);";
 
     my $intranetuserjs = C4::Context->preference('intranetuserjs');
-    if ( $intranetuserjs eq $bad_value ) {
+    if ($intranetuserjs  and  $intranetuserjs eq $bad_value) {
         my $sql = <<'END_SQL';
 UPDATE systempreferences
 SET value = ''
-- 
1.5.5.GIT



More information about the Koha-patches mailing list