[Koha-patches] [PATCH] patch followup: restore test in GetMarcItem

Galen Charlton galen.charlton at liblime.com
Wed Jan 7 01:54:18 CET 2009


Change made to GetMarcItem to quell a warning
changed sense of a test; defined($foo) is *not*
the same as $foo ne ''.
---
 C4/Items.pm |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/C4/Items.pm b/C4/Items.pm
index a59dc51..98e6586 100644
--- a/C4/Items.pm
+++ b/C4/Items.pm
@@ -1521,7 +1521,11 @@ sub GetMarcItem {
 
     # Tack on 'items.' prefix to column names so that TransformKohaToMarc will work.
     # Also, don't emit a subfield if the underlying field is blank.
-    my $mungeditem = { map {  defined($itemrecord->{$_}) ? ("items.$_" => $itemrecord->{$_}) : ()  } keys %{ $itemrecord } };
+    my $mungeditem = { 
+        map {  
+            defined($itemrecord->{$_}) && $itemrecord->{$_} ne '' ? ("items.$_" => $itemrecord->{$_}) : ()  
+        } keys %{ $itemrecord } 
+    };
     my $itemmarc = TransformKohaToMarc($mungeditem);
 
     my $unlinked_item_subfields = _parse_unlinked_item_subfields_from_xml($mungeditem->{'items.more_subfields_xml'});
-- 
1.5.5.GIT




More information about the Koha-patches mailing list