[Koha-patches] [PATCH] C4::Context::userenv reloaded

[Galen Charlton]

Hi,

On Mon, Nov 10, 2008 at 11:34 AM, Marc Chantreux
<marc.chantreux at biblibre.com> wrote:
> it was hard to find a bug in our module because userenv does not report what
> was going on. I rewrote it to be more verbose in error cases.

I'm rejecting this patch: during testing, when I try to use
selectbranchprinter.pl to change the active branch, it crashes with
the following error message:

no active user. Perhaps you forgot to load C4::Auth and use
get_template_and_user at /home/gmc/koha/dev/C4/Context.pm line 892.

> +    $context->preference('insecure') and return {qw(
> +       flags 16382
> +       branchname Insecure
> +       number 0
> +       cardnumber 0
> +       id Insecure
> +       branch INS
> +       emailaddress test at mode.insecure.com
> +    )};
> +    die "no userenv without insecure mode";

If you resubmit, please also make the hashref literal look like it
actually contains a hash, not an array, i.e., I consider this more
readable:

... and return {
    flags => 16382,
    branchname => 'Insecure',
    # etc.
}

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt