[Koha-patches] [PATCH] [PATCH] [PATCH][3.2][Replace Previous] (bug #1578) Add the (quasi)full COinS(Zotero) support

[Galen Charlton]

Hi,

On Thu, Jan 8, 2009 at 5:41 AM, Nahuel ANGELINETTI
<nahuel.angelinetti at biblibre.com> wrote:
> this patch do a lot of things :
>  * Add the function GetCOinSBiblio in C4::Biblio, return the COinS value that must be put in a span title
>   This will be usefull for OpenURL support.
>
>  * Replace the span in opac-detail, and put the var get from GetCOinSBiblio
>  * Fix an <img> tag that wasn't autoclosed
>  * Add the COinS in search result
>  * Full COinS support of UNIMARC, the MARC21 support should be improved to provide all kind of document types

Better, but not quite there - warnings are now enabled in C4::Biblio,
and some from the new function are showing up in the Apache log:

Biblio.pm: Useless use of a constant in void context at
/home/gmc/koha/dev/C4/Biblio.pm line 992.
Biblio.pm: Useless use of a constant in void context at
/home/gmc/koha/dev/C4/Biblio.pm line 993.
Biblio.pm: Useless use of a constant in void context at
/home/gmc/koha/dev/C4/Biblio.pm line 994.
Biblio.pm: Useless use of a constant in void context at
/home/gmc/koha/dev/C4/Biblio.pm line 995.
opac-detail.pl: Use of uninitialized value in concatenation (.) or
string at /home/gmc/koha/dev/C4/Biblio.pm line 998.

Once this is fixed and the patch resubmitted, I will be ready to push it.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt